update step by step integration with react navigation#1498
update step by step integration with react navigation#1498TitusEfferian wants to merge 3 commits into
Conversation
|
Deploy preview for react-native ready! Built with commit 8a25db7 https://deploy-preview-1498--react-native.netlify.com Changes to Thank you for your contributions. |
osdnk
left a comment
osdnk
left a comment
There was a problem hiding this comment.
look great! many thanks! Can you just address these comments? :)
| ## React Navigation | ||
|
|
||
| The community solution to navigation is a standalone library that allows developers to set up the screens of an app with a few lines of code. | ||
| The community solution to navigation is a standalone library that allows developers to set up the screens of an app with a few lines of code. Assuming you are on the latest react-native version. |
There was a problem hiding this comment.
Can you rephrase it? React Navigation works with some older versions. What's the point of this sentence? It sounds a bit strange.
There was a problem hiding this comment.
sorry i missed this one to remove from my commit 🙏, it just a local change test because it's my first time trying to contribute here 🙏
| ``` | ||
|
|
||
| The second step is to install react-native-gesture-handler | ||
| The second step is to install additional dependencies such as `react-native-gesture-handler`, `react-native-reanimated`, and `react-native-screens`: |
There was a problem hiding this comment.
and react-native-safe-area-context and masked-view
There was a problem hiding this comment.
okay, and already joined into one line here -> 571f5ed
| ``` | ||
|
|
||
| ``` | ||
| yarn add react-native-screens |
There was a problem hiding this comment.
can you join then into one command like:
npm install react-native-reanimated react-native-gesture-handler react-native-screens react-native-safe-area-context @react-native-community/masked-view.
Also, we in react-navigation are now not supportive of using yarn, so If you want, feel free to mention only npm (nit).
nearestnabors
left a comment
nearestnabors
left a comment
There was a problem hiding this comment.
Please address @osdnk's suggestions so I can merge!
|
oops, |
5 participants
Motivation
when i created fresh project with latest react-native version, and i wanted to integrate react navigation to my project, i followed step by step instruction from http://facebook.github.io/react-native/docs/navigation and it got an error.
But i found out that the current documentation missed out some step.
here is my pull request give an additional steps with the current react navigation version.
and here is some screenshot of additional step in my changes:
1. install dependencies
2. finishing up with android or iOS development target
